Bump Metro dependencies #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Dec 19, 2018
| @@ -27,10 +27,10 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/core": "^7.1.5", | |||
| "@babel/plugin-transform-strict-mode": "^7.2.0", | |||
There was a problem hiding this comment.
oh, forgot we use babel/register here. time to make a proper build/watch infra :p
There was a problem hiding this comment.
Yeah, so called "post-merge" review 😂
|
Going to bundle few apps before this lands, just to make sure everything works as expected. |
Esemesek
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new Metro resolver as per facebook/react-native@f5cb4b6 in React Native and bumps Metro version to the latest.
Once this is merged, we are going to make a new "alpha" release and bump the React Native dependency.
This package will go out of alpha before next React Native RC, once we finish the whole migration process.